I never 100% trust iCloud; there always seem to be some edge cases with delayed sync between desktop and iOS etc. I have my org-files in an iCloud drive folder, but have set up Emacs to automatically commit my org files on save, and to push the commits to a remote repository.